X2-8303 | X2-8266 | X2-8421 | refactor sidebar to control drawers fro… #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojx031
approved these changes
Jan 12, 2024
rushi
requested changes
Jan 12, 2024
src/components/Sidebar/Sidebar.jsx
Outdated
| @@ -169,6 +129,9 @@ Sidebar.propTypes = { | |||
| isStickyHeader: PropTypes.bool, | |||
| isStickyFooter: PropTypes.bool, | |||
| onLogoClick: PropTypes.func.isRequired, | |||
| isLeftDrawerOpen: PropTypes.bool.isRequired, | |||
| isRightDrawerOpen: PropTypes.bool.isRequired, | |||
| handleDrawerStateChange: PropTypes.func.isRequired, | |||
There was a problem hiding this comment.
I don't think handleDrawerStateChange, isLeftDrawerOpen and isRightDrawerOpen should be required because not all consumers of the Sidebar component will be implementing the a drawer with the Sidebar.
rushi
approved these changes
Jan 12, 2024
rushi
added a commit
to rushi/ui-kit
that referenced
this pull request
Jan 29, 2024
…eact # By Rushi Vishavadia (44) and others # Via GitHub (13) and others * 'master' of github.com:xola/ui-kit: (155 commits) 2.1.41 X2-8303 | X2-8266 | X2-8421 | refactor sidebar to control drawers fro… (xola#300) Defaulted context to empty object if undefined X2-8166 fix(breakdown): resolves context destructuring issue 2.1.39 X2-8166 Correct Currency not Appearing when Viewing the Customer's Reservation in the Purchases Tab (xola#296) 2.1.38 2.1.37 Revert "X2-8166: Correct Currency not Appearing when Viewing the Customer's Reservation in the Purchases Tab" (xola#294) 2.1.36 X2-8166: Correct Currency not Appearing when Viewing the Customer's Reservation in the Purchases Tab (xola#292) Fix currency display issue in BreakdownItem component Add locale prop to Breakdown component 2.1.35 X2-6577 Tutorial - Fix (xola#291) Fix for CAD with Canadian locale 2.1.34 X2 7053 feedback widget (xola#266) 2.1.33 X2-6907 Setting default as no date for DatePickerPopover [LATEST] (xola#289) ... # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m outside. Also, do not close drawer on data change.